Paths

Table of Contentst

Differential D214

'when' access strategy - Ref T805
ClosedPublic
Actions

Authored by kuba-orlik on Mar 30 2018, 16:13.

Tags

None

Referenced Files

	F1262434: D214.diff
	Wed, Jan 22, 03:44

	F1262423: D214.id727.diff
	Wed, Jan 22, 01:34

	F1262410: D214.diff
	Tue, Jan 21, 22:57

	F1262379: D214.id735.diff
	Tue, Jan 21, 20:23

	F1262378: D214.id727.diff
	Tue, Jan 21, 20:23

	F1262377: D214.id721.diff
	Tue, Jan 21, 20:23

	F1262364: D214.id.diff
	Tue, Jan 21, 20:13

	Unknown Object (File)
	Fri, Jan 10, 16:59

Subscribers

piotr-ptaszynski

Details

Reviewers

piotr-ptaszynski

Group Reviewers

Unknown Object (Project)

Maniphest Tasks

Unknown Object (Maniphest Task)

Commits

rSbadbf12ea3ba: 'when' access strategy - Ref T805
rSadb9f6ba1fd7: 'when' access strategy - Ref T805

Summary

See tests for usage

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kuba-orlik requested review of this revision.Mar 30 2018, 16:13

kuba-orlik created this revision.

Harbormaster completed remote builds in B519: Diff 721.Mar 30 2018, 16:13

kuba-orlik added a task: Unknown Object (Maniphest Task).Mar 30 2018, 16:31

kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".

Bardzo fajna metastrategia. Są pewne uwagi, ale raczej non-blocking.

lib/app/base-chips/access-strategy-types/or.js
23	O kurde nie przyszło mi to do głowy +1 !
lib/app/base-chips/access-strategy-types/when.js
50	(question) Ok, wypisujemy błąd - ale równocześnie go połykamy, tak ma być?
lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.js
36	(could) Mam wątpliwości czy to jest dobra nazwa dla filtrów - jako twórca nazwy `getRestrictionQuery` kierowałem się tym, że "restriction" kojarzy się z ograniczaniem dostępu, a to nie jest zadanie filtru. Na przykład `getFilteringQuery` pasowałoby bardziej.
lib/datastore/query.js
147	(should) W klasie `Query` są już metody statyczne zadeklarowane za pomocą `static` i trzymałbym się tego.

bartosz-gordon subscribed.Mar 31 2018, 10:19

bartosz-gordon added inline comments.

lib/app/base-chips/access-strategy-types/or.js
23	Lubię widzieć takie zmiany :D

Zastosowałem się do sugestii, wprowadziłem też kilka zmian - upubliczniłem interfejs SpecialFilters, nie trzeba go teraz ręcznie require'ować

lib/app/base-chips/access-strategy-types/when.js
50	Uuu tego tu powinno nie być, to artefakt po debuggowaniu.

Review fixes, making the filters interface public

Harbormaster completed remote builds in B525: Diff 727.Mar 31 2018, 14:40

Oddaję do ponownego review ;)

piotr-ptaszynski accepted this revision.Apr 4 2018, 09:15

This revision is now accepted and ready to land.Apr 4 2018, 09:15

Closed by commit rSadb9f6ba1fd7: 'when' access strategy - Ref T805. · Explain WhyApr 4 2018, 10:37

This revision was automatically updated to reflect the committed changes.

kuba-orlik added a commit: rSbadbf12ea3ba: 'when' access strategy - Ref T805.Jul 23 2020, 08:11

Revision Contents
Changeset List

Path

Size

lib/

app/

7 lines

base-chips/

access-strategy-types/

access-strategy-types.test.js

1 line

6 lines

39 lines

69 lines

when.subtest.js

67 lines

field-types/

single_reference.js

2 lines

special_filters/

IsReferencedByResourcesMatching.js

83 lines

IsReferencedByResourcesMatching.subtest.js

3 lines

load-special-filters.js

4 lines

56 lines

matches.subtest.js

5 lines

load-base-chips.js

1 line

chip-types/

16 lines

special-filter.js

42 lines

datastore/

37 lines

Diff 735

lib/app/app.js

Loading...

lib/app/base-chips/access-strategy-types/access-strategy-types.test.js

Loading...

lib/app/base-chips/access-strategy-types/logged_in.js

Loading...

lib/app/base-chips/access-strategy-types/or.js

Loading...

lib/app/base-chips/access-strategy-types/when.js

Loading...

lib/app/base-chips/access-strategy-types/when.subtest.js

Loading...

lib/app/base-chips/field-types/single_reference.js

Loading...

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.js

Loading...

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.subtest.js

Loading...

lib/app/base-chips/special_filters/load-special-filters.js

Loading...

lib/app/base-chips/special_filters/matches.js

Loading...

lib/app/base-chips/special_filters/matches.subtest.js

Loading...

lib/app/load-base-chips.js

Loading...

lib/chip-types/collection.js

Loading...

lib/chip-types/special-filter.js

Loading...

lib/datastore/query.js

Loading...