Paths

Table of Contentst

Differential D362

ESLint config and error fixes
AbandonedPublic
Actions

Authored by bartosz-gordon on Sep 30 2018, 11:29.

Details

Reviewers

kuba-orlik

Group Reviewers

Unknown Object (Project)

Maniphest Tasks

Unknown Object (Maniphest Task)

Summary

Add base eslint/prettier config

Do not use public/private as properties

Fix eqeqeq

Fix dot notation

Fix no-else-return

Fix strict

Fix prefer-template

Fix prefer-arrow-callback

Fix object-shorthand

Fix no-var

Fix no-lonely-if

Make eslint up to date

Diff Detail

Repository

rS Sealious

Branch

T1118 (branched from alpha)

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1011
Build 1011: arc lint + arc unit

Event Timeline

bartosz-gordon created this revision.Sep 30 2018, 11:29

Checklista diffów do sealiousa:

EJKO działa poprawnie (make test + testy manualne) - jeżeli nie, zrobić odpowiedniego diffa do EJKO
sealious-template działa poprawnie (make test)- jeżeli nie, zrobić odpowiedniego diffa do sealious-template
aktualizacja dokumentacji
czy wszystko nadal się zgadza w getting_started

bartosz-gordon requested review of this revision.Sep 30 2018, 11:29

Harbormaster completed remote builds in B956: Diff 1291.Sep 30 2018, 11:29

bartosz-gordon planned changes to this revision.Sep 30 2018, 11:29

Fix no-negated-condition
Remove unused variables
No redundant await
Radix
no-undef
Consistent callbacks

Harbormaster completed remote builds in B957: Diff 1292.Sep 30 2018, 13:26

bartosz-gordon planned changes to this revision.Sep 30 2018, 13:26

no-prototype-builtin
line between class members
return in callback
class-methods-use-this
no-throw-literal
no-useless-escape
no-shadow
prefer-spread

Harbormaster completed remote builds in B966: Diff 1302.Oct 3 2018, 16:50

bartosz-gordon planned changes to this revision.Oct 3 2018, 16:50

no-params-reassign

Harbormaster completed remote builds in B968: Diff 1304.Oct 3 2018, 18:59

bartosz-gordon retitled this revision from Run fixable rules to ESLint config and error fixes.Oct 3 2018, 19:00

bartosz-gordon edited the test plan for this revision. (Show Details)

@kuba-orlik Chciałbym, żebyś zerknął na zakomentowane linie oznaczone jako TO DISCUSS i każdą z nich odkomentował i puścił npm run lint. Wtedy możemy ocenić, czy warto zmieniać te rzeczy w Sealiousie :)

bartosz-gordon added a reviewer: Unknown Object (Project).Oct 4 2018, 09:19

O ile pamiętam, to planowaliśmy wrzucić ten konfig jako reużywalny sealcode'owy - tak, aby w .exlintrc wystarczyło podać "sealcode" - czy planujesz to zrobić w ramach tego diffa?

.eslintrc
22	Pieczołowicie przerobiłem cały kod tak, aby nie robił awaitów w pętlach. `time make test` zwraca bardzo przybliżone wyniki. Ale trzeba pamiętać o tym, że w testach nie robimy zapytań na wiele zasobów (co najwyżej na ~6), więc to może nie być miarodajne. Myślę, że warto pamiętać o tym, że można robić pętle wydajniej. Dajmy na `warning`.
61	Jestem za tym, aby to włączyć na co najmniej 1. Pomoże to zapobiegać na poleganiu na tym, że funkcja zwraca `undefined` itp. Albo coś zwracamy w każdym scenariuszu, albo nie zwracamy nic
121	Kiedyś miałem GENIALNY pomysł, aby realizować zgłaszanie błędów strategii dostępu i field-type'ów za pomocą rzucania exceptions. Dlatego mamy dużo `return Promise.reject("message")`. Ustawmy to na 1, aby nie zapomnieć tego naprawić.
137	Ja jestem na tak (żeby to ustawić na 2). Skąd wątpliwości?
139	jeżeli dodamy `"functions": false` to imho będzie OK
150	Nigdy nie powinniśmy blokować wątku. Moim zdaniem to koniecznie trzeba ustawić na `2`.
183	imho może tak zostać (tylko trzeba zmienić "warning" na "warn"
184	Jest ok, możemy ew. zwiększyć limit do 75 linijek. I wyłączyć tę zasadę dla plików *.subtest
186	Zmiana tego wymaga fundamentalnego przebudowania API Sealiousa. Zob. {T1147}
191	ustawmy na 0

kuba-orlik requested changes to this revision.Oct 4 2018, 18:46

This revision now requires changes to proceed.Oct 4 2018, 18:46

Zapomniałem o tym, zrobię to ;)

.eslintrc
137	Ta zasada generuje ponad 60 errorów. Bardziej niż o jej słuszność, chodzi mi o to, czy nie wyrzucić tego do osobnego taska. Bo w wielu miejsach polegamy na `undefined` i wiąże się to z dużym refaktorem logiki. Można by ten task połączyć z wyeliminowaniem błędów z `consistent-return` :)

Refactor file manager
Refactor file manager
Assign tasks to eslint rules

Harbormaster completed remote builds in B1010: Diff 1356.Oct 10 2018, 18:19

bartosz-gordon planned changes to this revision.Oct 10 2018, 18:19

Use shareable eslint-config-sealcode

Harbormaster completed remote builds in B1011: Diff 1357.Oct 10 2018, 19:31

bartosz-gordon edited the test plan for this revision. (Show Details)Oct 10 2018, 19:33

Przejrałem pliki wyrywkowo i nie znalazałem nieprawidłowości. Testy przechodzą, program do zarządzania magazynami działa (zarówno TEST jak i POPULATE)

This revision is now accepted and ready to land.Oct 11 2018, 12:10

kuba-orlik added a project: Sealious.Oct 11 2018, 12:11

kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".

bartosz-gordon abandoned this revision.Jul 16 2019, 17:50

Large Diff

This large diff affects 158 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

.eslintrc

3 lines

.prettierrc

1 line

lib/

action.js

2 lines

app/

app.js

16 lines

base-chips/

access-strategy-types/

27 lines

4 lines

10 lines

5 lines

23 lines

17 lines

57 lines

8 lines

12 lines

5 lines

12 lines

same-as-for-resource-in-field.js

13 lines

same-as-for-resource-in-field.subtest.js

27 lines

super.js

13 lines

themselves.js

9 lines

user-referenced-in-field.js

2 lines

user-referenced-in-field.subtest.js

2 lines

users-who-can.js

8 lines

when.js

5 lines

when.subtest.js

1 line

calculated-field-types/

aggregate.js

13 lines

custom.js

5 lines

map-reduce.js

17 lines

collections/

formatted-images.js

1 line

password-reset-intents.subtest.js

7 lines

registration-intents.subtest.js

13 lines

users.js

1 line

users.subtest.js

12 lines

field-types/

boolean.js

15 lines

cached-value.js

67 lines

cached-value.subtest.js

99 lines

color.js

5 lines

context.js

10 lines

control-access.js

4 lines

control-access.subtest.js

46 lines

date.js

8 lines

datetime.js

17 lines

derived-value.js

44 lines

derived-value.subtest.js

35 lines

10 lines

8 lines

16 lines

68 lines

10 lines

6 lines

41 lines

22 lines

10 lines

json-object.subtest.js

3 lines

password.js

33 lines

reverse-single-reference.js

18 lines

reverse-single-reference.subtest.js

15 lines

secret-token.js

3 lines

settable-by.js

16 lines

settable-by.subtest.js

2 lines

single_reference.js

39 lines

single_reference.subtest.js

10 lines

text.js

21 lines

text.subtest.js

2 lines

username.js

7 lines

value-existing-in-collection.js

15 lines

value-exists-in-collection.js

24 lines

value-not-existing-in-collection.js

5 lines

special_filters/

IsReferencedByResourcesMatching.js

1 line

IsReferencedByResourcesMatching.subtest.js

2 lines

2 lines

18 lines

8 lines

107 lines

10 lines

4 lines

3 lines

6 lines

11 lines

chip-types/

access-strategy-type.js

47 lines

access-strategy.js

1 line

aggregated-field.js

5 lines

calculated-field-type.js

4 lines

4 lines

3 lines

3 lines

109 lines

142 lines

1 line

field-type-default-methods.js

31 lines

4 lines

8 lines

2 lines

23 lines

data-structures/

field-type-description.js

3 lines

file.js

4 lines

subject-path.js

2 lines

virtual-file.js

3 lines

datastore/

db.js

26 lines

graph.js

13 lines

mongo-api-abstract.js

96 lines

8 lines

24 lines

23 lines

6 lines

8 lines

4 lines

4 lines

email/

logger-mailer.js

5 lines

message.js

1 line

smtp-mailer.js

10 lines

templates/

simple.js

2 lines

http/

2 lines

8 lines

24 lines

4 lines

11 lines

2 lines

19 lines

routes/

account-creation-details.js

4 lines

confirm-password-reset.js

17 lines

confirm-password-reset.subtest.js

3 lines

finalize-password-reset.js

6 lines

finalize-password-reset.subtest.js

8 lines

finalize-registration-intent.js

6 lines

finalize-registration-intent.subtest.js

3 lines

setup-routes.js

3 lines

main.js

1 line

response/

error.js

11 lines

response.js

3 lines

responses.js

4 lines

subject/

predefined-subjects/

collections-subject.js

1 line

1 line

3 lines

4 lines

5 lines

5 lines

1 line

49 lines

subject-types/

_batch_action.js

16 lines

collection-field-subject.js

10 lines

collection-subject.js

96 lines

current-session-subject.js

2 lines

image-format.js

172 lines

image-formats.js

4 lines

single-file-subject.js

9 lines

single-resource-subject.js

77 lines

single-specification-subject.js

3 lines

subject.js

10 lines

super-context.js

7 lines

utils/

array-cartesian.js

9 lines

flatten-object-to-dot-notation.js

4 lines

get-datetime.js

8 lines

get-main-app-dir.js

1 line

integer-cartesian.js

42 lines

promise-iterate-generator.js

5 lines

secure-hasher.js

1 line

package.json

14 lines

test_utils/

assert_throws_async.js

1 line

Commit	Tree	Parents	Author	Summary	Date
3f752b7e1863	63e03aefe877	7f82c1a8fa35	Bartosz Gordon	Use shareable eslint-config-sealcode	Oct 10 2018, 19:31
7f82c1a8fa35	a768e31001f1	44a5658cb8df	Bartosz Gordon	Assign tasks to eslint rules	Oct 10 2018, 18:05
44a5658cb8df	61b90041a2b4	d7ce064269f7	Bartosz Gordon	Refactor file manager	Oct 10 2018, 17:45
d7ce064269f7	4db25c363594	3ae957219137	Bartosz Gordon	Refactor file manager	Oct 9 2018, 21:56
3ae957219137	7e9fd3cac288	42b81b154658	Bartosz Gordon	no-params-reassign	Oct 3 2018, 18:53
42b81b154658	00692872f93b	734b9b53f297	Bartosz Gordon	prefer-spread	Oct 3 2018, 16:48
734b9b53f297	baffce0595a4	9ae7b0191da1	Bartosz Gordon	no-shadow	Oct 3 2018, 16:40
9ae7b0191da1	344214de4f8f	3bfff026e369	Bartosz Gordon	no-useless-escape	Oct 3 2018, 16:01
3bfff026e369	7b9e372be3c9	3efb387f1967	Bartosz Gordon	no-throw-literal	Oct 3 2018, 15:56
3efb387f1967	580a3cfa037d	0e8488d73dd8	Bartosz Gordon	class-methods-use-this	Oct 3 2018, 15:53
0e8488d73dd8	bfd2c24c8b13	75c4df9089a5	Bartosz Gordon	return in callback	Oct 2 2018, 15:23
75c4df9089a5	fed554355f6f	ecc077bfc975	Bartosz Gordon	line between class members	Oct 2 2018, 15:16
ecc077bfc975	642463d41fe3	0e99d82a86b8	Bartosz Gordon	no-prototype-builtin	Oct 1 2018, 22:12
0e99d82a86b8	7b709233803f	026c9844b228	Bartosz Gordon	Consistent callbacks	Sep 30 2018, 13:24
026c9844b228	de4ef17eceec	e13469df751a	Bartosz Gordon	no-undef	Sep 30 2018, 12:30
e13469df751a	5ce4820ffe56	31378ac215da	Bartosz Gordon	Radix	Sep 30 2018, 12:20
31378ac215da	1a32e5be6d13	e2695d2b88a8	Bartosz Gordon	No redundant await	Sep 30 2018, 12:14
e2695d2b88a8	f637bfccd077	c167a4d6cba6	Bartosz Gordon	Remove unused variables	Sep 30 2018, 12:04
c167a4d6cba6	de4a15e6b2f0	0fac47549083	Bartosz Gordon	Fix no-negated-condition	Sep 30 2018, 11:38
0fac47549083	3225e768e9ba	137c189b54fd	Bartosz Gordon	Run fixable rules (Show More…)	Sep 30 2018, 11:27
137c189b54fd	34dcc591bd94	7737f021cd52	Bartosz Gordon	Fix no-lonely-if	Sep 30 2018, 11:24
7737f021cd52	f6ebfe73e987	56866a7f831f	Bartosz Gordon	Fix no-var	Sep 30 2018, 11:21
56866a7f831f	876627e5197b	44583ec6ea92	Bartosz Gordon	Fix object-shorthand	Sep 30 2018, 11:18
44583ec6ea92	87e767179659	70627f687aed	Bartosz Gordon	Fix prefer-arrow-callback	Sep 30 2018, 11:17
70627f687aed	4cfb0e672458	3f908b5b6dba	Bartosz Gordon	Fix prefer-template	Sep 30 2018, 11:16
3f908b5b6dba	b4af16624d70	1c5649906160	Bartosz Gordon	Fix strict	Sep 30 2018, 11:14
1c5649906160	197436a95ae8	0fdf1699580e	Bartosz Gordon	Fix no-else-return	Sep 30 2018, 11:11
0fdf1699580e	6614bc2fddde	917343147873	Bartosz Gordon	Fix dot notation	Sep 30 2018, 11:06
917343147873	214f875525cb	340a13642d37	Bartosz Gordon	Fix eqeqeq	Sep 30 2018, 11:06
340a13642d37	bd1c6facc727	88c9a1a55d37	Bartosz Gordon	Do not use public/private as properties	Sep 30 2018, 11:00
88c9a1a55d37	daba8f4d6173	c5a2ce17ffaa	Bartosz Gordon	Add basic eslint/prettier config	Sep 30 2018, 10:56

ESLint config and error fixesAbandonedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 1357

.eslintrc

.prettierrc

lib/action.js

lib/app/app.js

lib/app/base-chips/access-strategy-types/and.js

lib/app/base-chips/access-strategy-types/and.subtest.js

lib/app/base-chips/access-strategy-types/logged_in.js

lib/app/base-chips/access-strategy-types/noone.js

lib/app/base-chips/access-strategy-types/not.js

lib/app/base-chips/access-strategy-types/not.subtest.js

lib/app/base-chips/access-strategy-types/or.js

lib/app/base-chips/access-strategy-types/or.subtest.js

lib/app/base-chips/access-strategy-types/owner.js

lib/app/base-chips/access-strategy-types/public.js

lib/app/base-chips/access-strategy-types/same-anon.js

lib/app/base-chips/access-strategy-types/same-as-for-resource-in-field.js

lib/app/base-chips/access-strategy-types/same-as-for-resource-in-field.subtest.js

lib/app/base-chips/access-strategy-types/super.js

lib/app/base-chips/access-strategy-types/themselves.js

lib/app/base-chips/access-strategy-types/user-referenced-in-field.js

lib/app/base-chips/access-strategy-types/user-referenced-in-field.subtest.js

lib/app/base-chips/access-strategy-types/users-who-can.js

lib/app/base-chips/access-strategy-types/when.js

lib/app/base-chips/access-strategy-types/when.subtest.js

lib/app/base-chips/calculated-field-types/aggregate.js

lib/app/base-chips/calculated-field-types/custom.js

lib/app/base-chips/calculated-field-types/map-reduce.js

lib/app/base-chips/collections/formatted-images.js

lib/app/base-chips/collections/password-reset-intents.subtest.js

lib/app/base-chips/collections/registration-intents.subtest.js

lib/app/base-chips/collections/users.js

lib/app/base-chips/collections/users.subtest.js

lib/app/base-chips/field-types/boolean.js

lib/app/base-chips/field-types/cached-value.js

lib/app/base-chips/field-types/cached-value.subtest.js

lib/app/base-chips/field-types/color.js

lib/app/base-chips/field-types/context.js

lib/app/base-chips/field-types/control-access.js

lib/app/base-chips/field-types/control-access.subtest.js

lib/app/base-chips/field-types/date.js

lib/app/base-chips/field-types/datetime.js

lib/app/base-chips/field-types/derived-value.js

lib/app/base-chips/field-types/derived-value.subtest.js

lib/app/base-chips/field-types/email.js

lib/app/base-chips/field-types/enum.js

lib/app/base-chips/field-types/file-reference.js

lib/app/base-chips/field-types/file.js

lib/app/base-chips/field-types/float.js

lib/app/base-chips/field-types/html.js

lib/app/base-chips/field-types/image.js

lib/app/base-chips/field-types/int.js

lib/app/base-chips/field-types/json-object.js

lib/app/base-chips/field-types/json-object.subtest.js

lib/app/base-chips/field-types/password.js

lib/app/base-chips/field-types/reverse-single-reference.js

lib/app/base-chips/field-types/reverse-single-reference.subtest.js

lib/app/base-chips/field-types/secret-token.js

lib/app/base-chips/field-types/settable-by.js

lib/app/base-chips/field-types/settable-by.subtest.js

lib/app/base-chips/field-types/single_reference.js

lib/app/base-chips/field-types/single_reference.subtest.js

lib/app/base-chips/field-types/text.js

lib/app/base-chips/field-types/text.subtest.js

lib/app/base-chips/field-types/username.js

lib/app/base-chips/field-types/value-existing-in-collection.js

lib/app/base-chips/field-types/value-exists-in-collection.js

lib/app/base-chips/field-types/value-not-existing-in-collection.js

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.js

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.subtest.js

lib/app/base-chips/special_filters/matches.subtest.js

lib/app/chip-manager.js

lib/app/config-manager.js

lib/app/file-manager.js

ESLint config and error fixes
AbandonedPublic
Actions

Revision Contents
Changeset List