Page MenuHomeSealhub

Eksportować ładnie CollectionValidationResult
Closed, ResolvedPublic0.25 Points

Description

Rozwiązać problem opisany w tym komentarzu: https://hub.sealcode.org/D1237#inline-10980

Details

Tested by
kuba-orlik
Coded by
michal1024
Reviewed by
kuba-orlik
Action required from
michal1024
PHID of the last column the processing script has seen this task in
PHID-PCOL-rt4p72bfiw2fnfkxc5fl
Timestamp of the time this task got moved into the current column
1650887435232

Revisions and Commits

Event Timeline

jenkins-user set Timestamp of the time this task got moved into the current column to 1650887085544.Apr 25 2022, 13:44
jenkins-user set PHID of the last column the processing script has seen this task in to PHID-PCOL-2ksh7xlolko4ggqo7rez.
jenkins-user changed Timestamp of the time this task got moved into the current column from 1650887085544 to 1650887435232.Apr 25 2022, 13:50
jenkins-user changed PHID of the last column the processing script has seen this task in from PHID-PCOL-2ksh7xlolko4ggqo7rez to PHID-PCOL-rt4p72bfiw2fnfkxc5fl.
kuba-orlik shifted this object from the Restricted Space space to the S5 Publiczna space.Oct 30 2023, 13:28
kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".
michal1024 moved this task from To do to Doing on the Kanban board.
jenkins-user updated Action required from, added: michal1024.

Cześć, mam pare pytań:

  1. Między dev a master są spore różnice, na której gałęzi powinienem pracować?
  2. Task polega na dodaniu exportów w kodzie Sealiousa tak?
  3. Sprawdzenie czy visual studio pokazuje dobry plik po kliknięciu eksporta z controlem jest wystarczającym testem?
  1. Prace są na gałęzi dev
  2. Tak 👍
  3. Aby to sprawdzić, najlepiej zbudować kod sealiousa (npm run build), sklonować rPLAY Sealious playground i podlinkować tam sealiousa za pomocą npm link (https://docs.npmjs.com/cli/v6/commands/npm-link) i sprawdzić w jakimś IDE, czy można ładnie zaimportować typ CollectionValidationResult z Sealiousa
michal1024 added a revision: Restricted Differential Revision.May 22 2024, 01:11
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: FilipI; removed: michal1024.
jenkins-user added a subscriber: michal1024.
jenkins-user updated Reviewed by, added: kuba-orlik.
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: FilipI.
jenkins-user updated Tested by, added: kuba-orlik.
jenkins-user moved this task from Ready for testing to Ready to land on the Kanban board.
jenkins-user updated Action required from, added: michal1024; removed: AmeliaB, Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak.