Page MenuHomeSealhub
Create Task
Maniphest T2594

Eksportować ładnie CollectionValidationResult
Closed, ResolvedPublic0.25 Points
Actions

Description

Rozwiązać problem opisany w tym komentarzu: https://hub.sealcode.org/D1237#inline-10980

Details

Tested by
kuba-orlik
Coded by
michal1024
Reviewed by
kuba-orlik
Action required from
michal1024
PHID of the last column the processing script has seen this task in
PHID-PCOL-rt4p72bfiw2fnfkxc5fl
Timestamp of the time this task got moved into the current column
1650887435232

Revisions and Commits

rS Sealious
Restricted Differential RevisionrS4ce562e1c732 added exports for CollectionValidationResult and CollectionItemBody, changed…

Event Timeline

kuba-orlik created this task.Apr 25 2022, 13:44
Herald added a project: Kanban. · View Herald TranscriptApr 25 2022, 13:44
jenkins-user set Timestamp of the time this task got moved into the current column to 1650887085544.Apr 25 2022, 13:44
jenkins-user set PHID of the last column the processing script has seen this task in to PHID-PCOL-2ksh7xlolko4ggqo7rez.
kuba-orlik moved this task from Freezer (don't take those tasks just yet) to To do on the Kanban board.Apr 25 2022, 13:50
jenkins-user changed Timestamp of the time this task got moved into the current column from 1650887085544 to 1650887435232.Apr 25 2022, 13:50
jenkins-user changed PHID of the last column the processing script has seen this task in from PHID-PCOL-2ksh7xlolko4ggqo7rez to PHID-PCOL-rt4p72bfiw2fnfkxc5fl.
kuba-orlik shifted this object from the Restricted Space space to the S5 Publiczna space.Oct 30 2023, 13:28
kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".
kuba-orlik updated the task description. (Show Details)Oct 30 2023, 19:54
michal1024 claimed this task.Mar 17 2024, 21:25
michal1024 moved this task from To do to Doing on the Kanban board.
jenkins-user updated Coded by, added: michal1024.Mar 17 2024, 21:25
jenkins-user updated Action required from, added: michal1024.
michal1024 added a comment.Mar 21 2024, 18:09

Cześć, mam pare pytań:

  1. Między dev a master są spore różnice, na której gałęzi powinienem pracować?
  2. Task polega na dodaniu exportów w kodzie Sealiousa tak?
  3. Sprawdzenie czy visual studio pokazuje dobry plik po kliknięciu eksporta z controlem jest wystarczającym testem?
kuba-orlik added a comment.Mar 25 2024, 20:24
  1. Prace są na gałęzi dev
  2. Tak 👍
  3. Aby to sprawdzić, najlepiej zbudować kod sealiousa (npm run build), sklonować rPLAY Sealious playground i podlinkować tam sealiousa za pomocą npm link (https://docs.npmjs.com/cli/v6/commands/npm-link) i sprawdzić w jakimś IDE, czy można ładnie zaimportować typ CollectionValidationResult z Sealiousa
michal1024 added a revision: Restricted Differential Revision.May 22 2024, 01:11
jenkins-user removed michal1024 as the assignee of this task.May 22 2024, 01:11
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: FilipI; removed: michal1024.
jenkins-user added a subscriber: michal1024.
jenkins-user assigned this task to michal1024.May 23 2024, 08:43
jenkins-user updated Reviewed by, added: kuba-orlik.
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: FilipI.
jenkins-user updated Tested by, added: kuba-orlik.
jenkins-user moved this task from Ready for testing to Ready to land on the Kanban board.
jenkins-user updated Action required from, added: michal1024; removed: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak.
michal1024 added a commit: rS4ce562e1c732: added exports for CollectionValidationResult and CollectionItemBody, changed….May 23 2024, 17:15
jenkins-user moved this task from Ready to land to Done on the Kanban board.May 23 2024, 17:16
kuba-orlik closed this task as Resolved.Jun 2 2024, 15:38