Page MenuHomeSealhub
Create Task
Maniphest T2725

Prevent scaling images up
Closed, ResolvedPublic1 Points
Actions

Description

There's no need to resize an image to a size that's larger than the original image. In order to prevent that, we should:

  • ignore all resolutions that are higher than the original resolution of the image
  • if there are any resolutions that are higher than the original resolution, replace them with single resolution that corresponds to the original image's resolution

The points above apply also to the resolutions passed in resulting HTML.

We should cache the information about original image size to avoid probing the original image on every HTML request.

Details

Tested by
kuba-orlik
Coded by
luryxyt
Reviewed by
kuba-orlik
Action required from
luryxyt

Revisions and Commits

rRIMAGEROUTER koa-responsive-image-router
Restricted Differential RevisionrRIMAGEROUTERb7d3f7f0dacf Prevent scaling images up

Event Timeline

kuba-orlik created this task.Sep 7 2023, 07:32
Herald added a project: Kanban. · View Herald TranscriptSep 7 2023, 07:32
kuba-orlik moved this task from Freezer (don't take those tasks just yet) to To do on the Kanban board.Sep 7 2023, 07:32
luryxyt subscribed.Sep 7 2023, 14:13
luryxyt claimed this task.Sep 7 2023, 14:23
luryxyt moved this task from To do to Doing on the Kanban board.
jenkins-user updated Coded by, added: luryxyt.Sep 7 2023, 14:24
jenkins-user updated Action required from, added: luryxyt.
luryxyt added a revision: Restricted Differential Revision.Sep 7 2023, 14:39
jenkins-user removed luryxyt as the assignee of this task.Sep 7 2023, 14:39
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: KamilBaczkowski, prostyfranek, Wirusik, wrzesinski-hubert, FilipI, brtkuu; removed: luryxyt.
jenkins-user assigned this task to luryxyt.Sep 7 2023, 20:54
jenkins-user moved this task from Review to Doing on the Kanban board.
jenkins-user updated Reviewed by, added: kuba-orlik.
jenkins-user updated Action required from, added: luryxyt; removed: KamilBaczkowski, prostyfranek, Wirusik, wrzesinski-hubert, FilipI, brtkuu.
jenkins-user reassigned this task from luryxyt to kuba-orlik.Sep 7 2023, 22:37
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: luryxyt.
jenkins-user reassigned this task from kuba-orlik to luryxyt.Sep 9 2023, 20:17
jenkins-user moved this task from Review to Doing on the Kanban board.
jenkins-user updated Action required from, added: luryxyt; removed: kuba-orlik.
jenkins-user reassigned this task from luryxyt to kuba-orlik.Sep 9 2023, 21:46
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: luryxyt.
jenkins-user reassigned this task from kuba-orlik to luryxyt.Sep 14 2023, 19:14
jenkins-user moved this task from Review to Doing on the Kanban board.
jenkins-user updated Action required from, added: luryxyt; removed: kuba-orlik.
jenkins-user reassigned this task from luryxyt to kuba-orlik.Sep 16 2023, 08:55
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: luryxyt.
jenkins-user removed kuba-orlik as the assignee of this task.Sep 22 2023, 20:22
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: kuba-orlik.
jenkins-user assigned this task to luryxyt.Sep 22 2023, 20:28
jenkins-user moved this task from Ready for testing to Doing on the Kanban board.
jenkins-user updated Tested by, added: kuba-orlik.
jenkins-user updated Action required from, added: luryxyt; removed: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak.
jenkins-user reassigned this task from luryxyt to kuba-orlik.Sep 23 2023, 00:15
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: luryxyt.
jenkins-user moved this task from Review to Ready for testing on the Kanban board.Oct 20 2023, 19:26
jenkins-user reassigned this task from kuba-orlik to luryxyt.Oct 20 2023, 19:31
jenkins-user moved this task from Ready for testing to Ready to land on the Kanban board.
jenkins-user updated Action required from, added: luryxyt; removed: kuba-orlik.
luryxyt added a commit: rRIMAGEROUTERb7d3f7f0dacf: Prevent scaling images up.Oct 28 2023, 15:13
jenkins-user moved this task from Ready to land to Done on the Kanban board.Oct 28 2023, 15:13
kuba-orlik shifted this object from the Restricted Space space to the S5 Publiczna space.Oct 30 2023, 13:22
kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".
kuba-orlik edited projects, added Open-source; removed Restricted Project.Oct 30 2023, 13:35
kuba-orlik closed this task as Resolved.Nov 21 2023, 09:54