Page MenuHomeSealhub
Create Task
Maniphest T2738

JSX support in Sealgen
Closed, ResolvedPublic2 Points
Actions

Description

The templates that Sealgen generates are based on old-school template-string tempstream syntax. Some examples include:

The goal is for Sealgen to have proper support for the new shiny JSX support. Some changes will probably have to be made to the sealgen's build script, as well.

Details

Coded by
FilipI
Reviewed by
kuba-orlik
Action required from
AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak

Revisions and Commits

Restricted Differential Revision
rPLAY Sealious playground
Restricted Differential RevisionrPLAY7df920534ccd Changes for jsx from tempstream
rSGEN sealgen
Audit RequiredRestricted Differential RevisionrSGENc5b3f666c0a3 Convert sealgen templates into tsx
rSTREAM tempstream
Audit RequiredRestricted Differential RevisionrSTREAM8213f4cc00fe Update for JSX types + handling void tags

Event Timeline

kuba-orlik created this task.Oct 30 2023, 19:16
Herald added a project: Kanban. · View Herald TranscriptOct 30 2023, 19:16
kuba-orlik moved this task from Freezer (don't take those tasks just yet) to To do on the Kanban board.Oct 30 2023, 19:18
kuba-orlik changed the point value for this task from 1 to 2.Oct 31 2023, 11:47
kuba-orlik added a project: Paid.Oct 31 2023, 12:03
FilipI moved this task from To do to Doing on the Kanban board.Nov 9 2023, 17:39
jenkins-user assigned this task to FilipI.Nov 9 2023, 17:39
jenkins-user updated Coded by, added: FilipI.
jenkins-user updated Action required from, added: FilipI.
FilipI added a revision: Restricted Differential Revision.Nov 9 2023, 19:32
kuba-orlik added a revision: Restricted Differential Revision.Dec 16 2023, 14:36
jenkins-user removed FilipI as the assignee of this task.Dec 16 2023, 14:36
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: KamilBaczkowski, prostyfranek, Wirusik, wrzesinski-hubert, brtkuu.
jenkins-user added a subscriber: FilipI.
jenkins-user assigned this task to FilipI.Dec 16 2023, 14:44
jenkins-user moved this task from Review to Doing on the Kanban board.
jenkins-user updated Reviewed by, added: kuba-orlik.
jenkins-user updated Action required from, removed: KamilBaczkowski, prostyfranek, Wirusik, wrzesinski-hubert, brtkuu.
FilipI added a revision: Restricted Differential Revision.Jan 4 2024, 19:58
FilipI added a revision: Restricted Differential Revision.Jan 23 2024, 00:51
jenkins-user reassigned this task from FilipI to kuba-orlik.Jan 24 2024, 01:03
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: FilipI.
FilipI added a comment.Jan 30 2024, 16:27

Prace nad tym taskime zostaly zakonczone.

Testowanie

Aby to przetestowac nalezy w repozytorium sealgen oraz sealious-playground zmienic wersje tempstream na "tempstream": "^0.1.1-alpha.2", oraz zrobic npm install. Nastepnie zbudowac sealgena i przetestowac go w repo sealious-playground odpalajac go nodem np.

node ../sealgen/lib/cli.js build

Jezeli ten ticket przejdzie testowanie nalezy wyldowac wszystkie 3 diffy w nastepujacy sposob

Ladowanie

Aby wyladowac ten ticket najpierw nalezy

  1. wyladowac D1357 oraz opublikowac nowa wersje tempstream (0.1.1) na npm.
  2. Nastepnie zupdatowac wersje tempstreama w sealgen oraz sealious-playground na 0.1.1 i zrobic npm install aby zupdateowac pakcage lock
  3. Nastepnue wyldowac nalezy D1359 (sealgen) oraz opublikowac nowa wersje na npm
  4. Nastepnie nowa wersje sealgena nalezy ustwaic w sealious-playground (D1363), zrobic npm install, zupdtowac diffa i wyladowac

a tym etapie powinnismy miec wszystkie repozytoria z nowym featurem

jenkins-user removed kuba-orlik as the assignee of this task.Jan 30 2024, 21:28
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: kuba-orlik.
kuba-orlik added a commit: rSTREAM8213f4cc00fe: Update for JSX types + handling void tags.Jan 30 2024, 21:29
jenkins-user moved this task from Ready for testing to Done on the Kanban board.Jan 30 2024, 21:29
jenkins-user assigned this task to kuba-orlik.Jan 31 2024, 02:03
jenkins-user moved this task from Done to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak.
jenkins-user reassigned this task from kuba-orlik to FilipI.Feb 1 2024, 19:18
jenkins-user moved this task from Review to Doing on the Kanban board.
jenkins-user updated Action required from, added: FilipI; removed: kuba-orlik.
jenkins-user reassigned this task from FilipI to kuba-orlik.Feb 1 2024, 19:20
jenkins-user removed kuba-orlik as the assignee of this task.
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: FilipI.
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: kuba-orlik.
FilipI added a commit: rSGENc5b3f666c0a3: Convert sealgen templates into tsx.Feb 1 2024, 19:21
jenkins-user moved this task from Ready for testing to Done on the Kanban board.Feb 1 2024, 19:21
jenkins-user assigned this task to kuba-orlik.Feb 1 2024, 19:57
jenkins-user moved this task from Done to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak.
jenkins-user removed kuba-orlik as the assignee of this task.Feb 1 2024, 20:00
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: kuba-orlik.
kuba-orlik added a commit: rPLAY7df920534ccd: Changes for jsx from tempstream.Feb 1 2024, 20:17
jenkins-user moved this task from Ready for testing to Done on the Kanban board.Feb 1 2024, 20:17
kuba-orlik closed this task as Resolved.Feb 12 2024, 12:21
kuba-orlik claimed this task.