Page MenuHomeSealhub
Create Task
Maniphest T2985

Fix 100 eslint issues in Sealious
Closed, ResolvedPublic1 Points
Actions

Description

Run npx eslint src in rS Sealious to see a list of errors and warnings. Fix any 200 of them that you choose. There are currently 1062 to choose from ;)

Details

Tested by
kuba-orlik
Reviewed by
kuba-orlik
Action required from
AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak

Revisions and Commits

rS Sealious
Restricted Differential RevisionrS0b3d4b6dcdad eslint fixes (832 remaining)

Event Timeline

kuba-orlik created this task.Jan 19 2025, 21:14
Herald added a project: Kanban. · View Herald TranscriptJan 19 2025, 21:14
kuba-orlik renamed this task from Fix 200 eslint issues in Sealious to Fix 100 eslint issues in Sealious.Jan 30 2025, 19:21
kuba-orlik moved this task from Freezer (don't take those tasks just yet) to To do on the Kanban board.
krzysztof subscribed.Jan 30 2025, 19:24

I agreed to fix 100 of them ^^

krzysztof added a comment.Feb 25 2025, 09:58

todo: https://www.npmjs.com/package/boom is deprecated

krzysztof added a comment.EditedFeb 25 2025, 10:15

-> 939 after eslint autofix
-> 832 after manual changes

krzysztof added a revision: Restricted Differential Revision.Feb 25 2025, 10:43
jenkins-user moved this task from To do to Review on the Kanban board.Feb 25 2025, 10:43
jenkins-user updated Action required from, added: FilipI.
kuba-orlik added a comment.Feb 26 2025, 14:28

nice! Will review asap 👍

jenkins-user updated Reviewed by, added: kuba-orlik.Sat, Apr 5, 15:37
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: FilipI.
jenkins-user updated Tested by, added: kuba-orlik.Sat, Apr 5, 17:19
jenkins-user moved this task from Ready for testing to Ready to land on the Kanban board.
krzysztof added a commit: rS0b3d4b6dcdad: eslint fixes (832 remaining).Sun, Apr 6, 19:02
jenkins-user moved this task from Ready to land to Done on the Kanban board.Sun, Apr 6, 19:02
kuba-orlik closed this task as Resolved.Mon, Apr 7, 19:05
kuba-orlik claimed this task.