Page MenuHomeSealhub
Create Task
Maniphest T3069

Properly escape tabs id
Closed, ResolvedPublic0.5 Points
Actions

Description

In https://hub.sealcode.org/source/sealious-playground/browse/master/src/back/routes/tabs-demo.page.tsx the IDs for the tabs are used as labels. But that can cause problems when the user wants labels to contain spaces. This task is about fixing that — remove all characters from the id/label of the tag that cannot be a part of id in HTML and replace them with ascii replacements (https://www.npmjs.com/package/normalize-diacritics) for word characters and for non-word characters — with hyphens

Details

Tested by
kuba-orlik
Coded by
ziomek
Reviewed by
kuba-orlik
Action required from
ziomek

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
rPLAY Sealious playground
Restricted Differential RevisionrPLAYd0e6203506c9 Normalize tab id
rAPROXY Assetproxy
Restricted Differential RevisionrAPROXYd0e6203506c9 Normalize tab id
rREWRITE Configurable rewriter
Restricted Differential RevisionrREWRITEd0e6203506c9 Normalize tab id

Event Timeline

kuba-orlik created this task.Oct 21 2025, 14:39
Herald added a project: Kanban. · View Herald TranscriptOct 21 2025, 14:39
kuba-orlik moved this task from Freezer (don't take those tasks just yet) to To do on the Kanban board.Oct 21 2025, 14:39
ziomek claimed this task.Oct 30 2025, 19:37
ziomek updated Coded by, added: ziomek.
ziomek moved this task from To do to Doing on the Kanban board.
jenkins-user updated Action required from, added: ziomek.Oct 30 2025, 19:37
ziomek added a revision: Restricted Differential Revision.Nov 3 2025, 16:41
jenkins-user removed ziomek as the assignee of this task.Nov 3 2025, 16:41
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: FilipI; removed: ziomek.
jenkins-user added a subscriber: ziomek.
jenkins-user assigned this task to ziomek.Nov 9 2025, 13:17
jenkins-user moved this task from Review to Doing on the Kanban board.
jenkins-user updated Reviewed by, added: kuba-orlik.
jenkins-user updated Action required from, added: ziomek; removed: FilipI.
jenkins-user reassigned this task from ziomek to kuba-orlik.Nov 20 2025, 16:48
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: ziomek.
jenkins-user removed kuba-orlik as the assignee of this task.Nov 27 2025, 19:32
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user updated Action required from, added: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak; removed: kuba-orlik.
jenkins-user assigned this task to ziomek.Nov 27 2025, 19:37
jenkins-user moved this task from Ready for testing to Doing on the Kanban board.
jenkins-user updated Tested by, added: kuba-orlik.
jenkins-user updated Action required from, added: ziomek; removed: AmeliaB, • Koossa, karolwojtowicz87, brtkuu, prostyfranek, zbartosz, radoptak.
jenkins-user reassigned this task from ziomek to kuba-orlik.Nov 28 2025, 17:26
jenkins-user moved this task from Doing to Review on the Kanban board.
jenkins-user updated Action required from, added: kuba-orlik; removed: ziomek.
jenkins-user reassigned this task from kuba-orlik to ziomek.Dec 4 2025, 19:33
jenkins-user moved this task from Review to Ready for testing on the Kanban board.
jenkins-user moved this task from Ready for testing to Ready to land on the Kanban board.
jenkins-user updated Action required from, added: ziomek; removed: kuba-orlik.
Restricted Repository Identity added a commit: rPLAYd0e6203506c9: Normalize tab id.Dec 4 2025, 19:49
jenkins-user moved this task from Ready to land to Done on the Kanban board.Dec 4 2025, 19:49
kuba-orlik closed this task as Resolved.Dec 10 2025, 16:59
Restricted Repository Identity added a commit: rREWRITEd0e6203506c9: Normalize tab id.Dec 24 2025, 13:21
Restricted Repository Identity added a commit: Restricted Diffusion Commit.Jan 21 2026, 16:34
Restricted Repository Identity added a commit: rAPROXYd0e6203506c9: Normalize tab id.May 14 2026, 19:29