Page MenuHomeSealhub
Differential D205

Improve field-type text
ClosedPublic
Actions

Authored by bartosz-gordon on Mar 27 2018, 08:04.
Tags
None
Referenced Files
F863915: D205.id688.diff
Sun, May 19, 08:01
F863843: D205.id.diff
Sun, May 19, 06:04
Unknown Object (File)
Wed, May 15, 02:04
Unknown Object (File)
Tue, May 14, 04:00
Unknown Object (File)
Fri, May 10, 18:14
Unknown Object (File)
Mon, May 6, 19:51
Unknown Object (File)
Thu, Apr 25, 20:12
Unknown Object (File)
Thu, Apr 25, 16:07
View All 38 Files
Subscribers
kuba-orlik

Details

Reviewers
kuba-orlik
Group Reviewers
Unknown Object (Project)
Maniphest Tasks
Unknown Object (Maniphest Task)
Commits
rSeaa8712bc9da: Improve field-type text
rS2383374178cd: Improve field-type text
Summary

Ref T786

Diff Detail

Repository
rS Sealious
Branch
T786 (branched from alpha)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 498
Build 498: arc lint + arc unit

Event Timeline

bartosz-gordon requested review of this revision.Mar 27 2018, 08:04
bartosz-gordon created this revision.
Harbormaster completed remote builds in B498: Diff 688.Mar 27 2018, 08:04
kuba-orlik accepted this revision as: Unknown Object (Project).Mar 27 2018, 16:13
kuba-orlik subscribed.

Props że Ci się chciało napisać testy, co jest bardzo słusznym podejściem :3

kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".Mar 27 2018, 16:13
kuba-orlik accepted this revision.Mar 27 2018, 18:03
This revision is now accepted and ready to land.Mar 27 2018, 18:03
Closed by commit rS2383374178cd: Improve field-type text. · Explain WhyMar 27 2018, 18:35
This revision was automatically updated to reflect the committed changes.
Restricted Repository Identity added a commit: rSeaa8712bc9da: Improve field-type text.Jul 23 2020, 08:10

Revision Contents
Changeset List

PathSize
lib/
app/
base-chips/
field-types/
1 line
112 lines
86 lines

Diff 688

View Options

lib/app/base-chips/field-types/field-types.test.js

Loading...
View Options

lib/app/base-chips/field-types/text.js

Loading...
View Options

lib/app/base-chips/field-types/text.subtest.js

Loading...