Page MenuHomeSealhub
Differential D214

'when' access strategy - Ref T805
ClosedPublic
Actions

Authored by kuba-orlik on Mar 30 2018, 16:13.
Tags
None
Referenced Files
F970754: D214.diff
Sun, Nov 24, 00:10
Unknown Object (File)
Fri, Nov 22, 04:47
Unknown Object (File)
Thu, Nov 21, 22:45
Unknown Object (File)
Thu, Nov 14, 10:11
Unknown Object (File)
Sun, Nov 10, 05:45
Unknown Object (File)
Sat, Nov 9, 06:13
Unknown Object (File)
Mon, Nov 4, 19:45
Unknown Object (File)
Tue, Oct 29, 08:37
View All Files
Subscribers
bartosz-gordon
piotr-ptaszynski

Details

Reviewers
piotr-ptaszynski
Group Reviewers
Unknown Object (Project)
Maniphest Tasks
Unknown Object (Maniphest Task)
Commits
rSbadbf12ea3ba: 'when' access strategy - Ref T805
rSadb9f6ba1fd7: 'when' access strategy - Ref T805
Summary

See tests for usage

Diff Detail

Repository
rS Sealious
Branch
when (branched from alpha)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 525
Build 525: arc lint + arc unit

Event Timeline

kuba-orlik requested review of this revision.Mar 30 2018, 16:13
kuba-orlik created this revision.
Harbormaster completed remote builds in B519: Diff 721.Mar 30 2018, 16:13
kuba-orlik added a task: Unknown Object (Maniphest Task).Mar 30 2018, 16:31
kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".
piotr-ptaszynski accepted this revision as: Unknown Object (Project).Mar 30 2018, 19:18
piotr-ptaszynski subscribed.

Bardzo fajna metastrategia. Są pewne uwagi, ale raczej non-blocking.

lib/app/base-chips/access-strategy-types/or.js
23

O kurde nie przyszło mi to do głowy +1 !

lib/app/base-chips/access-strategy-types/when.js
50

(question)
Ok, wypisujemy błąd - ale równocześnie go połykamy, tak ma być?

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.js
36

(could)
Mam wątpliwości czy to jest dobra nazwa dla filtrów - jako twórca nazwy getRestrictionQuery kierowałem się tym, że "restriction" kojarzy się z ograniczaniem dostępu, a to nie jest zadanie filtru. Na przykład getFilteringQuery pasowałoby bardziej.

lib/datastore/query.js
147

(should)
W klasie Query są już metody statyczne zadeklarowane za pomocą static i trzymałbym się tego.

bartosz-gordon subscribed.Mar 31 2018, 10:19
bartosz-gordon added inline comments.
lib/app/base-chips/access-strategy-types/or.js
23

Lubię widzieć takie zmiany :D

kuba-orlik planned changes to this revision.Mar 31 2018, 14:36
kuba-orlik marked 5 inline comments as done.

Zastosowałem się do sugestii, wprowadziłem też kilka zmian - upubliczniłem interfejs SpecialFilters, nie trzeba go teraz ręcznie require'ować

lib/app/base-chips/access-strategy-types/when.js
50

Uuu tego tu powinno nie być, to artefakt po debuggowaniu.

kuba-orlik updated this revision to Diff 727.Mar 31 2018, 14:40
kuba-orlik marked an inline comment as done.
  • Review fixes, making the filters interface public
Harbormaster completed remote builds in B525: Diff 727.Mar 31 2018, 14:40
kuba-orlik added a comment.Mar 31 2018, 14:40

Oddaję do ponownego review ;)

piotr-ptaszynski accepted this revision.Apr 4 2018, 09:15
This revision is now accepted and ready to land.Apr 4 2018, 09:15
Closed by commit rSadb9f6ba1fd7: 'when' access strategy - Ref T805. · Explain WhyApr 4 2018, 10:37
This revision was automatically updated to reflect the committed changes.
kuba-orlik added a commit: rSbadbf12ea3ba: 'when' access strategy - Ref T805.Jul 23 2020, 08:11

Revision Contents
Changeset List

PathSize
lib/
app/
7 lines
base-chips/
access-strategy-types/
1 line
6 lines
39 lines
69 lines
67 lines
field-types/
2 lines
special_filters/
83 lines
3 lines
4 lines
56 lines
5 lines
1 line
chip-types/
16 lines
42 lines
datastore/
37 lines

Diff 727

View Options

lib/app/app.js

Loading...
View Options

lib/app/base-chips/access-strategy-types/access-strategy-types.test.js

Loading...
View Options

lib/app/base-chips/access-strategy-types/logged_in.js

Loading...
View Options

lib/app/base-chips/access-strategy-types/or.js

Loading...
View Options

lib/app/base-chips/access-strategy-types/when.js

Loading...
View Options

lib/app/base-chips/access-strategy-types/when.subtest.js

Loading...
View Options

lib/app/base-chips/field-types/single_reference.js

Loading...
View Options

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.js

Loading...
View Options

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.subtest.js

Loading...
View Options

lib/app/base-chips/special_filters/load-special-filters.js

Loading...
View Options

lib/app/base-chips/special_filters/matches.js

Loading...
View Options

lib/app/base-chips/special_filters/matches.subtest.js

Loading...
View Options

lib/app/load-base-chips.js

Loading...
View Options

lib/chip-types/collection.js

Loading...
View Options

lib/chip-types/special-filter.js

Loading...
View Options

lib/datastore/query.js

Loading...