Page MenuHomeSealhub

Fix filtering via http
ClosedPublic

Authored by bartosz-gordon on Jun 1 2018, 06:59.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 20:19
Unknown Object (File)
Wed, Mar 27, 04:17
Unknown Object (File)
Wed, Mar 27, 04:17
Unknown Object (File)
Wed, Mar 27, 04:17
Unknown Object (File)
Wed, Mar 27, 04:17
Unknown Object (File)
Wed, Mar 27, 04:17
Unknown Object (File)
Wed, Mar 27, 02:07
Unknown Object (File)
Mon, Mar 25, 09:16

Details

Reviewers
piotr-ptaszynski
kuba-orlik
Group Reviewers
Unknown Object (Project)
Maniphest Tasks
Unknown Object (Maniphest Task)
Commits
rS0f8720c09aee: Fix filtering via http
rS3ba845547237: Fix filtering via http
Summary

Ref T928

  • Refactor tests vol2
  • Fix filtering via http

Diff Detail

Repository
rS Sealious
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartosz-gordon created this revision.
  • Fix cached-value decode method
  • Make cached-value handlers context-aware
kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".Jun 1 2018, 21:19
piotr-ptaszynski subscribed.

Idzie accept z jedną uwagą

lib/app/base-chips/field-types/cached-value.subtest.js
37

(should)

Czy przypadkiem ten context nie powinien być tutaj wykorzystany?

lib/app/base-chips/field-types/single_reference.subtest.js
99

O kurde :D

This revision is now accepted and ready to land.Jun 2 2018, 13:24
bartosz-gordon added inline comments.
lib/app/base-chips/field-types/cached-value.subtest.js
37

@kuba-orlik Dla pewności - w tym miejscu nie powinniśmy polegać na context'ie użytkownika?

lib/app/base-chips/field-types/cached-value.subtest.js
37

Co do zasady tak, chociaż na ten test to nie wpłynie

Akcept, z jednym komentarzem :)

lib/app/base-chips/field-types/single_reference.subtest.js
7–9

Myślę, że te trzy stałe lepiej przenieść do it-a, którego dotyczą

This revision was automatically updated to reflect the committed changes.