Page MenuHomeSealhub
Differential D288

Fix filtering via http
ClosedPublic
Actions

Authored by bartosz-gordon on Jun 1 2018, 06:59.
Tags
None
Referenced Files
F969804: D288.diff
Thu, Nov 21, 22:29
Unknown Object (File)
Mon, Nov 18, 05:08
Unknown Object (File)
Sun, Nov 10, 03:53
Unknown Object (File)
Sat, Nov 9, 22:37
Unknown Object (File)
Fri, Nov 8, 22:03
Unknown Object (File)
Tue, Nov 5, 00:38
Unknown Object (File)
Mon, Nov 4, 19:46
Unknown Object (File)
Sun, Nov 3, 11:32
View All Files
Subscribers
kuba-orlik
piotr-ptaszynski

Details

Reviewers
piotr-ptaszynski
kuba-orlik
Group Reviewers
Unknown Object (Project)
Maniphest Tasks
Unknown Object (Maniphest Task)
Commits
rS0f8720c09aee: Fix filtering via http
rS3ba845547237: Fix filtering via http
Summary

Ref T928

  • Refactor tests vol2
  • Fix filtering via http

Diff Detail

Repository
rS Sealious
Branch
T928 (branched from alpha)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 710
Build 710: arc lint + arc unit

Event Timeline

bartosz-gordon requested review of this revision.Jun 1 2018, 06:59
bartosz-gordon created this revision.
Harbormaster completed remote builds in B710: Diff 981.Jun 1 2018, 06:59
bartosz-gordon updated this revision to Diff 982.Jun 1 2018, 11:17
  • Fix cached-value decode method
Harbormaster completed remote builds in B711: Diff 982.Jun 1 2018, 11:17
bartosz-gordon updated this revision to Diff 983.Jun 1 2018, 15:39
  • Make cached-value handlers context-aware
Harbormaster completed remote builds in B712: Diff 983.Jun 1 2018, 15:39
bartosz-gordon updated this revision to Diff 984.Jun 1 2018, 17:20
  • Fix super-context
Harbormaster completed remote builds in B713: Diff 984.Jun 1 2018, 17:20
kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".Jun 1 2018, 21:19
piotr-ptaszynski accepted this revision.Jun 2 2018, 13:24
piotr-ptaszynski subscribed.

Idzie accept z jedną uwagą

lib/app/base-chips/field-types/cached-value.subtest.js
37 ↗(On Diff #984)

(should)

Czy przypadkiem ten context nie powinien być tutaj wykorzystany?

lib/app/base-chips/field-types/single_reference.subtest.js
99

O kurde :D

This revision is now accepted and ready to land.Jun 2 2018, 13:24
bartosz-gordon added a subscriber: kuba-orlik.Jun 5 2018, 10:26
bartosz-gordon added inline comments.
lib/app/base-chips/field-types/cached-value.subtest.js
37 ↗(On Diff #984)

@kuba-orlik Dla pewności - w tym miejscu nie powinniśmy polegać na context'ie użytkownika?

kuba-orlik added inline comments.Jun 6 2018, 10:39
lib/app/base-chips/field-types/cached-value.subtest.js
37 ↗(On Diff #984)

Co do zasady tak, chociaż na ten test to nie wpłynie

bartosz-gordon marked 4 inline comments as done.Jun 6 2018, 11:17
kuba-orlik accepted this revision.Jun 6 2018, 11:25

Akcept, z jednym komentarzem :)

lib/app/base-chips/field-types/single_reference.subtest.js
7–9

Myślę, że te trzy stałe lepiej przenieść do it-a, którego dotyczą

bartosz-gordon marked an inline comment as done.Jun 6 2018, 11:36
Closed by commit rS3ba845547237: Fix filtering via http. · Explain WhyJun 6 2018, 11:39
This revision was automatically updated to reflect the committed changes.
Restricted Repository Identity added a commit: rS0f8720c09aee: Fix filtering via http.Jul 23 2020, 08:11

Revision Contents
Changeset List

PathSize
lib/
app/
base-chips/
field-types/
2 lines
153 lines

Diff 981

View Options

lib/app/base-chips/field-types/single_reference.js

Loading...
View Options

lib/app/base-chips/field-types/single_reference.subtest.js

Loading...