HomeSealhub

In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a…

Description

In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list

Summary:
Ref T13588. The behavior of "call_user_func_array()" has changed in PHP8, and the function now attempts to use array keys as argument names.

This always fails when calling "array_merge()" (which does not accept named parameters), and may cause misbehavior in the general case.

Guarantee the argument is a natural list (with keys "0", "1", "2", ...).

Test Plan:

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21551

Details

Provenance
epriestleyAuthored on Feb 8 2021, 19:13
kuba-orlikPushed on Jan 24 2022, 10:17
Parents
R118:32fe933f3ae7: Add a lint check for catching "Exception" without catching "Throwable"
Branches
Unknown
Tags
Unknown

Event Timeline