Diffusion Arcanist - fork c51a996fb0bb

Detect and correct "final private" methods in lint
c51a996fb0bb
Actions

Description

Detect and correct "final private" methods in lint

Summary:
Ref T13588. Marking a method "final private" has never been meaningful, and is an error in PHP8.

Add static analysis to detect (and correct) this issue.

Test Plan: Added unit tests, will lint "phabricator/".

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21539

Details

Provenance

epriestley	Authored on Feb 3 2021, 22:46
kuba-orlik	Pushed on Jan 24 2022, 10:17

Parents

R118:e2b6439a734b: Allow lint to correct the spelling of builtin symbols

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (3)

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistInvalidModifiersXHPASTLinterRule.php

__tests__/

invalid-modifiers/

invalid-modifiers.lint-test

parser/

aast/

api/

AASTToken.php

R118:c51a996fb0bb

View Options

src/lint/linter/xhpast/rules/ArcanistInvalidModifiersXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/invalid-modifiers/invalid-modifiers.lint-test

View Options

src/parser/aast/api/AASTToken.php

Detect and correct "final private" methods in lintc51a996fb0bbActions

Description

Details

Event Timeline

Changes (3)

R118:c51a996fb0bb

src/lint/linter/xhpast/rules/ArcanistInvalidModifiersXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/invalid-modifiers/invalid-modifiers.lint-test

src/parser/aast/api/AASTToken.php

Detect and correct "final private" methods in lint
c51a996fb0bb
Actions

src/lint/linter/xhpast/rules/tests/invalid-modifiers/invalid-modifiers.lint-test