HomeSealhub

Add a lint check for deprecated argument order to "implode()"

Description

Add a lint check for deprecated argument order to "implode()"

Summary:
Ref T13428. Historically, "implode()" accepts arguments in either order. PHP 7.4+ warns about glue not being first.

Add a lint check when the second parameter is a static scalar, implying it is the glue parameter.

Test Plan: Ran unit tests. See next change.

Maniphest Tasks: T13428

Differential Revision: https://secure.phabricator.com/D20857

Details

Provenance
epriestleyAuthored on Oct 17 2019, 17:27
kuba-orlikPushed on Jan 24 2022, 10:17
Parents
R118:3cdfe1fff806: When running "arc land" from a detached HEAD, don't try to delete the source ref
Branches
Unknown
Tags
Unknown

Event Timeline