HomeSealhub

Allow `setCustomSeverityRules` to be overridden in subclasses

Description

Allow setCustomSeverityRules to be overridden in subclasses

Summary:
I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change ({D19630}) was previously accepted.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D20514

Details

Provenance
Joshua SpenceAuthored on May 15 2019, 01:03
kuba-orlikPushed on Jan 24 2022, 10:17
Parents
R118:4f583dded366: Call `$linter->setEngine` in linter tests
Branches
Unknown
Tags
Unknown

Event Timeline