In every place where we interpolate some value coming in from user input in Sealgen's FormControls, we should make sure that the values are properly escaped with https://www.npmjs.com/package/escape-goat in order to avoid them messing up the structure of the HTML.
Description
Description
Details
Details
- Coded by
- jenkins-user
- Reviewed by
- kuba-orlik
- Action required from
- kuba-orlik
Revisions and Commits
Revisions and Commits
| Restricted Differential Revision |
Event Timeline
Comment Actions
I made all the changes and i think i got them all so there should be no HTML injections on users end:) but whenever i make a arc diff origin/master and save changes my laptop freezes up and wont make a diff. I will try to fix that in the morning.
Comment Actions
i Don't know why i didn't think of it in the first place. I think my brain is bit fried:) Thank you so much
Comment Actions
No worries — it *should* work without that flag, but good to know you managed to make it running. Did you submit the diff successfully? If so, it wasn't attached to the task
Comment Actions
Ok looks like i messed up something in branches and now im lost how to get back to the point where i finished working on T3067 and send the diff when i finish (i started working on T2679 linting issues). I will have to restart the whole process and start working on 3067 from the start(html escape) then i will send diff again and move to the next task.