Paths

Table of Contentst

Differential D350

Move collection fields to root in response
ClosedPublic
Actions

Authored by piotr-ptaszynski on Aug 26 2018, 12:02.

Tags

None

Referenced Files

	F970750: D350.diff
	Sat, Nov 23, 23:51

	Unknown Object (File)
	Fri, Nov 22, 21:08

	Unknown Object (File)
	Fri, Nov 22, 08:48

	Unknown Object (File)
	Mon, Nov 18, 16:53

	Unknown Object (File)
	Mon, Nov 18, 06:32

	Unknown Object (File)
	Thu, Nov 14, 03:14

	Unknown Object (File)
	Tue, Nov 12, 01:57

	Unknown Object (File)
	Sat, Nov 9, 04:01

Subscribers

None

Details

Reviewers

Group Reviewers

Unknown Object (Project)

Maniphest Tasks

T1076: Przenieść fieldy z body do korzenia

Commits

rS07b1ed9ba326: Move collection fields to root in response
rSf217b342a33f: Move collection fields to root in response

Summary

Diff Detail

Repository

Branch

piopta_move_collection_field_to_root (branched from alpha)

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 931
Build 931: arc lint + arc unit

Event Timeline

piotr-ptaszynski created this revision.Aug 26 2018, 12:02

Checklista diffów do sealiousa:

EJKO działa poprawnie (make test + testy manualne) - jeżeli nie, zrobić odpowiedniego diffa do EJKO
sealious-template działa poprawnie (make test)- jeżeli nie, zrobić odpowiedniego diffa do sealious-template
aktualizacja dokumentacji
czy wszystko nadal się zgadza w getting_started

piotr-ptaszynski requested review of this revision.Aug 26 2018, 12:02

Herald added a comment. · View Herald TranscriptAug 26 2018, 12:02

This comment was removed by kuba-orlik.

Harbormaster completed remote builds in B919: Diff 1244.Aug 26 2018, 12:02

Herald added a comment. · View Herald TranscriptAug 26 2018, 12:02

This comment was removed by kuba-orlik.

kuba-orlik added a child revision: Restricted Differential Revision.Aug 29 2018, 15:22

Kilka uwag (poza komentarzami inline):

Testy zwracają błąd:

114 passing (33s)
1 failing

1) special filters
     Matches
       returns only positive numbers when using filter:

    AssertionError [ERR_ASSERTION]: [ 2, 1 ] deepEqual [ 1, 2 ]
    + expected - actual

     [
    +  1
       2
    -  1
     ]
    
    at with_running_app (lib/app/base-chips/special_filters/matches.subtest.js:43:11)

Trzeba zaktualizować getting_started - odpowiedź HTTP w ostatnim przykładzie (na samym dole) zawiera body:

https://hub.sealcode.org/source/sealious/browse/alpha/getting_started/getting_started.md;4d69badf27290080929ac379586b3d0334456df8?as=remarkup

lib/app/base-chips/access-strategy-types/same-as-for-resource-in-field.subtest.js
123 ↗	(On Diff #1244)	To chyba jest niepożądane ;)

This revision now requires changes to proceed.Aug 29 2018, 15:43

Herald added a comment. · View Herald TranscriptAug 29 2018, 15:43

This comment was removed by kuba-orlik.

I jeszcze jedna rzecz - uruchomienie testów na sealious-template z patchem {D346} i podlinkowanym sealiousem z D350: Move collection fields to root in response daje error:

0 passing (2s)
1 failing

1) Collection users returns test user:
   TypeError: Cannot read property 'username' of undefined
    at Context.it (src/backend/collections/users.test.js:9:48)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Wiem z czego się biorą te różne rzeczy, ale poczekam aż wylądujesz D346

In D350#9647, @piotr-ptaszynski wrote:

Wiem z czego się biorą te różne rzeczy, ale poczekam aż wylądujesz D346

Done ;)

Remove race condition vulnerabilities in tests
Update getting started
Merge branch 'alpha' into piopta_move_collection_field_to_root

Harbormaster completed remote builds in B931: Diff 1260.Sep 12 2018, 07:46

kuba-orlik added a child revision: Restricted Differential Revision.Sep 12 2018, 18:38

kuba-orlik accepted this revision.Sep 18 2018, 16:26

This revision is now accepted and ready to land.Sep 18 2018, 16:26

Closed by commit rSf217b342a33f: Move collection fields to root in response. · Explain WhySep 19 2018, 05:39

This revision was automatically updated to reflect the committed changes.

piotr-ptaszynski mentioned this in rSTbecbd13a3fc9: Adjust to fields in root.Oct 2 2018, 14:55

kuba-orlik changed the visibility from "All Users" to "Public (No Login Required)".Feb 21 2019, 11:13

piotr-ptaszynski added a commit: rS07b1ed9ba326: Move collection fields to root in response.Jul 23 2020, 08:12

Revision Contents
Changeset List

Path

Size

cosealious-src/

1 line

lib/

ResourceDropdown.jsx

2 lines

mixins/

85 lines

getting_started/

getting_started.md

83 lines

lib/

app/

base-chips/

access-strategy-types/

24 lines

4 lines

2 lines

6 lines

same-as-for-resource-in-field.js

4 lines

user-referenced-in-field.js

5 lines

user-referenced-in-field.subtest.js

2 lines

2 lines

when.subtest.js

6 lines

collections/

password-reset-intents.js

4 lines

password-reset-intents.subtest.js

13 lines

registration-intents.js

4 lines

registration-intents.subtest.js

4 lines

users.subtest.js

4 lines

field-types/

cached-value.js

10 lines

cached-value.subtest.js

22 lines

control-access.subtest.js

6 lines

derived-value.js

2 lines

derived-value.subtest.js

23 lines

json-object.subtest.js

22 lines

password.subtest.js

6 lines

reverse-single-reference.js

20 lines

reverse-single-reference.subtest.js

49 lines

settable-by.subtest.js

4 lines

single_reference.js

2 lines

single_reference.subtest.js

7 lines

special_filters/

IsReferencedByResourcesMatching.js

4 lines

IsReferencedByResourcesMatching.subtest.js

38 lines

matches.subtest.js

36 lines

chip-types/

19 lines

16 lines

3 lines

datastore/

mongo-api-abstract.js

2 lines

email/

templates/

password-reset.js

4 lines

http/

extract-context.js

6 lines

routes/

finalize-password-reset.js

2 lines

finalize-registration-intent.js

6 lines

finalize-registration-intent.subtest.js

6 lines

subject/

predefined-subjects/

sessions-subject.js

6 lines

subject-types/

_batch_action.js

4 lines

collection-subject.js

12 lines

image-format.js

11 lines

single-resource-subject.js

10 lines

test_utils/

access-strategy-types/

create_strategies_with_complex_pipeline.js

2 lines

Diff 1260

cosealious-src/index.js

Loading...

cosealious-src/lib/ResourceDropdown.jsx

Loading...

cosealious-src/lib/mixins/form.jsx

Loading...

getting_started/getting_started.md

Loading...

lib/app/base-chips/access-strategy-types/not.subtest.js

Loading...

lib/app/base-chips/access-strategy-types/owner.js

Loading...

lib/app/base-chips/access-strategy-types/roles.js

Loading...

lib/app/base-chips/access-strategy-types/same-anon.js

Loading...

lib/app/base-chips/access-strategy-types/same-as-for-resource-in-field.js

Loading...

lib/app/base-chips/access-strategy-types/user-referenced-in-field.js

Loading...

lib/app/base-chips/access-strategy-types/user-referenced-in-field.subtest.js

Loading...

lib/app/base-chips/access-strategy-types/when.js

Loading...

lib/app/base-chips/access-strategy-types/when.subtest.js

Loading...

lib/app/base-chips/collections/password-reset-intents.js

Loading...

lib/app/base-chips/collections/password-reset-intents.subtest.js

Loading...

lib/app/base-chips/collections/registration-intents.js

Loading...

lib/app/base-chips/collections/registration-intents.subtest.js

Loading...

lib/app/base-chips/collections/users.subtest.js

Loading...

lib/app/base-chips/field-types/cached-value.js

Loading...

lib/app/base-chips/field-types/cached-value.subtest.js

Loading...

lib/app/base-chips/field-types/control-access.subtest.js

Loading...

lib/app/base-chips/field-types/derived-value.js

Loading...

lib/app/base-chips/field-types/derived-value.subtest.js

Loading...

lib/app/base-chips/field-types/json-object.subtest.js

Loading...

lib/app/base-chips/field-types/password.subtest.js

Loading...

lib/app/base-chips/field-types/reverse-single-reference.js

Loading...

lib/app/base-chips/field-types/reverse-single-reference.subtest.js

Loading...

lib/app/base-chips/field-types/settable-by.subtest.js

Loading...

lib/app/base-chips/field-types/single_reference.js

Loading...

lib/app/base-chips/field-types/single_reference.subtest.js

Loading...

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.js

Loading...

lib/app/base-chips/special_filters/IsReferencedByResourcesMatching.subtest.js

Loading...

lib/app/base-chips/special_filters/matches.subtest.js

Loading...

lib/chip-types/collection.js

Loading...

lib/chip-types/datastore.js

Loading...

lib/chip-types/field.js

Loading...

lib/datastore/mongo-api-abstract.js

Loading...

lib/email/templates/password-reset.js

Loading...

lib/http/extract-context.js

Loading...

lib/http/routes/finalize-password-reset.js

Loading...

lib/http/routes/finalize-registration-intent.js

Loading...

lib/http/routes/finalize-registration-intent.subtest.js

Loading...

lib/subject/predefined-subjects/sessions-subject.js

Loading...

lib/subject/subject-types/_batch_action.js

Loading...

lib/subject/subject-types/collection-subject.js

Loading...

lib/subject/subject-types/image-format.js

Loading...

lib/subject/subject-types/single-resource-subject.js

Loading...

test_utils/access-strategy-types/create_strategies_with_complex_pipeline.js

Loading...